[Refactor] Unify repo search order by logic #30876
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
6543
added
the
type/refactoring
GiteaBot
added
the
lgtm/need 2
pull-request-size
bot
added
the
size/L
6543
commented
May 6, 2024
6543
commented
May 6, 2024
github-actions
bot
added
the
modifies/api
6543
commented
May 6, 2024
|
I would say this refactor is ready ;) |
I will review and merge after v1.22 stable is released since it's a refactor PR. |
6543
added a commit
that referenced
this pull request
May 7, 2024
|
@lunny we now have v1.22.0 tagged :) |
lunny
reviewed
Jun 11, 2024
lunny
approved these changes
Jun 12, 2024
GiteaBot
added
lgtm/need 1
delvh
approved these changes
Jun 12, 2024
GiteaBot
added
lgtm/done
|
@delvh that are two valid refactors :) But as this is already taking that long i propose to make two small followup pulls adressing it :) |
|
The first one is a bug, not a refactor. |
wxiaoguang
reviewed
Jun 13, 2024
zjjhot
added a commit
to zjjhot/gitea
that referenced
this pull request
Jun 14, 2024
* giteaofficial/main: Extract and display readme and comments for Composer packages (go-gitea#30927) Have new announcement about docs contributions (go-gitea#31364) Fix bug filtering issues which have no project (go-gitea#31337) Refactor to use UnsafeStringToBytes (go-gitea#31358) [skip ci] Updated translations via Crowdin Fix PullRequestList.GetIssueIDs's logic (go-gitea#31352) [Refactor] Unify repo search order by logic (go-gitea#30876)
lunny
pushed a commit
that referenced
this pull request
Jun 15, 2024
DennisRasey
pushed a commit
to DennisRasey/forgejo
that referenced
this pull request
Jun 18, 2024
go-gitea/gitea#30876 (comment) (cherry picked from commit 78e8296e113e2fd9259ec05fe87035427821ea0b)
6543
added a commit
that referenced
this pull request
Sep 1, 2024
Fix #31916 In #30876, `sortOrder` has been changed into a map, but it is only implemented in explore. ~~But it seems that size sort order has no effect from long long ago,~~ not directly caused by the PR above. I think it is still caused by #29231. In #29231, it merged the sort orders from `templates/explore/repo_search.tmpl` and `templates/admin/repo/search.tmpl`. In `templates/admin/repo/search.tmpl`, it contains size sort orders, but not in `templates/explore/repo_search.tmpl`, which is used in non-admin pages. So `order by size` is added from #29231, but the handler was not added. --------- Co-authored-by: 6543 <[email protected]> Co-authored-by: wxiaoguang <[email protected]>
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
have repo OrderBy definitions defined in one place and use a single type for OrderBy database options